From 1a4121f8eeb56aec23520b0e19acf38ce420dd3e Mon Sep 17 00:00:00 2001 From: PhilippeVay Date: Sat, 28 Jun 2014 09:49:22 +0200 Subject: [PATCH 1/5] Typos --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 51003f0..3973917 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ KNACSS is a minimalist, responsive and extensible style sheet to kick-start your Designed by [Alsacreations agency](http://alsacreations.fr) and used on a daily basis in production, KNACSS is not only a lightweight documented framework but also a CSS reset, adapted to every project no matter its size. -It handles basic elements, box sizing, margins, floats, simple and complex aligns, positioning, layout grids, gutters, old IE fallbacks and last but not least responsiveness, everything automagically ! +It handles basic elements, box sizing, margins, floats, simple and complex aligns, positioning, layout grids, gutters, old IE fallbacks and last but not least responsiveness, everything automagically! Installation ----------- @@ -16,19 +16,19 @@ There is nothing to install. It is only a CSS file you can call as usual in the You can also install KNACSS with [Bower](http://bower.io/) : ```bower install knacss``` -... Or you can also choose the KNACSS Builder : http://knacss.com/builder/ +… Or you can also choose the KNACSS Builder : http://knacss.com/builder/ Usage ----- -KNACSS is a collection of ready to use styles and snippets to kick start your project. Feel free to use it as a “reset”, then make it grow to suit your needs. +KNACSS is a collection of ready to use styles and snippets to kick-start your project. Feel free to use it as a “reset”, then make it grow to suit your needs. Take the time to read the documentation before jumping in. Indeed, KNACSS doesn’t always suit beginners’ needs since a little thing can have big consequences. ## Vendor Prefixes -If you use one of the pre-processed version of KNACSS (LESS / Sass) know that all the properties are declared **without vendor prefixes** (-webkit-,-moz-,-ms-,…), to gain clarity, and length of initial code. +If you use one of the pre-processed version of KNACSS (LESS / Sass), beware that all the properties are declared **without vendor prefixes** (-webkit-,-moz-,-ms-,…), to gain clarity, and length of initial code. -You will certainely need to add these vendor prefixes yourself (this is usually done automatically today with Autoprefixer, Mixture, Prepros, Grunt, etc.). +You will certainly need to add these vendor prefixes yourself (this is usually done automatically today with Autoprefixer, Mixture, Prepros, Grunt, etc.). Useful links ------------ From 158eaa1b3f9a02d00b2350e9ffcc495c7f573820 Mon Sep 17 00:00:00 2001 From: PhilippeVay Date: Sat, 28 Jun 2014 10:11:49 +0200 Subject: [PATCH 2/5] Adding some URLs --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 3973917..91bff9e 100644 --- a/README.md +++ b/README.md @@ -28,10 +28,10 @@ Take the time to read the documentation before jumping in. Indeed, KNACSS doesn If you use one of the pre-processed version of KNACSS (LESS / Sass), beware that all the properties are declared **without vendor prefixes** (-webkit-,-moz-,-ms-,…), to gain clarity, and length of initial code. -You will certainly need to add these vendor prefixes yourself (this is usually done automatically today with Autoprefixer, Mixture, Prepros, Grunt, etc.). +You will certainly need to add these vendor prefixes yourself (this is usually done automatically today with Autoprefixer, [Mixture](http://mixture.io), [Prepros](http://alphapixels.com/prepros/), [Grunt](http://gruntjs.com), etc.). Useful links ------------ -* Website and download : http://knacss.com/ +* Website and download : http://knacss.com * Tutorial : http://knacss.com/demos/tutoriel.html * Commented code : http://knacss.com/knacss.html From 9b8b1f45ecb29e93b7c30e80f52849214a9098f9 Mon Sep 17 00:00:00 2001 From: PhilippeVay Date: Sat, 28 Jun 2014 10:14:22 +0200 Subject: [PATCH 3/5] Error in comment: s/small/medium --- less/00-config.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/less/00-config.less b/less/00-config.less index 9a460ec..b02deb4 100644 --- a/less/00-config.less +++ b/less/00-config.less @@ -43,7 +43,7 @@ // breakpoints @tiny-screen : 320px; // tiny screens media query @small-screen : 480px; // small screens media query -@medium-screen : 768px; // small screens media query +@medium-screen : 768px; // medium screens media query @large-screen : 1024px; // large screens media query @extra-large-screen : 1280px; // extra large screens media query @ultra-large-screen : 1600px; // ultra large screens media query From d72f2794671f0d87b268f6b25f735ad0f3c0c566 Mon Sep 17 00:00:00 2001 From: PhilippeVay Date: Sat, 28 Jun 2014 12:59:02 +0200 Subject: [PATCH 4/5] More explicit comments --- less/00-config.less | 2 +- less/01-base.less | 4 ++-- less/06-rwd.less | 4 ++-- less/11-ie.less | 1 + 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/less/00-config.less b/less/00-config.less index b02deb4..32ad13b 100644 --- a/less/00-config.less +++ b/less/00-config.less @@ -49,7 +49,7 @@ @ultra-large-screen : 1600px; // ultra large screens media query // misc -@gutter : 20px; // gutter value (%, px, em, rem) for grid layouts +@gutter : 20px; // gutter value for grid layouts. Unit can be: %, px, em, rem // LESS mixins : don't touch or you'll be banned ;) // px to em/rem diff --git a/less/01-base.less b/less/01-base.less index 48a4f87..a4938e4 100644 --- a/less/01-base.less +++ b/less/01-base.less @@ -1,6 +1,6 @@ @import "00-config"; /*! -* www.KNACSS.com V3.0.3 (2014-05-019) @author: Raphael Goetter, Alsacreations +* www.KNACSS.com V3.0.3 (2014-05-19) @author: Raphael Goetter, Alsacreations * Licence WTFPL http://www.wtfpl.net/ */ @@ -185,7 +185,7 @@ sup { /* == hiding content */ /* ----------------------------- */ -/* hidden but not for assistance tools, Yahoo! method */ +/* hidden but not for an assistive technology like a screen reader, Yahoo! method */ .visually-hidden { position: absolute !important; border: 0 !important; diff --git a/less/06-rwd.less b/less/06-rwd.less index 3195861..9da7e93 100644 --- a/less/06-rwd.less +++ b/less/06-rwd.less @@ -4,11 +4,11 @@ /* ----------------------------- */ @media (min-width: @small-screen) { -/* rules for big resources and big screens like: background-images, font-faces, etc. */ + /* rules for big resources and big screens like: background-images, font-faces, etc. */ } @media (-webkit-min-device-pixel-ratio: 2), (min-resolution: 192dpi), (min-resolution: 2dppx) { -/* style adjustments for high density devices */ + /* style adjustments for high density devices */ } /* ---------------------------------- */ diff --git a/less/11-ie.less b/less/11-ie.less index 1e68be4..0774f94 100644 --- a/less/11-ie.less +++ b/less/11-ie.less @@ -70,6 +70,7 @@ *zoom: 1; } + /* old syntax of clip for IE6/IE7 */ .visually-hidden { *clip: rect(1px 1px 1px 1px); } From 3f9c557d46cec1962a588cca37f342b0fcedfcad Mon Sep 17 00:00:00 2001 From: PhilippeVay Date: Sat, 28 Jun 2014 13:00:41 +0200 Subject: [PATCH 5/5] Consistency: semi-colon everywhere --- less/05-icons.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/less/05-icons.less b/less/05-icons.less index 61ed472..071e404 100644 --- a/less/05-icons.less +++ b/less/05-icons.less @@ -31,7 +31,7 @@ } .icon.after:before { - content: "" !important + content: "" !important; } .icon-rate:before,